Add error check that variable block restriction is correct for object…

… block restriction (closes idaholab#9889)
aeslaughter · Oct 23, 2017 · cc6bd8f · cc6bd8f
1 parent b2799b2
commit cc6bd8f
Show file tree

Hide file tree

Showing 4 changed files with 97 additions and 0 deletions.
diff --git a/framework/src/base/MooseVariableInterface.C b/framework/src/base/MooseVariableInterface.C
@@ -20,6 +20,9 @@
 #include "MooseVariable.h"
 #include "Problem.h"
 #include "SubProblem.h"
+#include "BlockRestrictable.h"
+#include "MooseMesh.h"
+#include "Conversion.h"
 
 MooseVariableInterface::MooseVariableInterface(const MooseObject * moose_object,
                                                bool nodal,
@@ -42,6 +45,27 @@ MooseVariableInterface::MooseVariableInterface(const MooseObject * moose_object,
   _variable = &problem.getVariable(tid, variable_name);
 
   _mvi_assembly = &problem.assembly(tid);
+
+  // Check for subdomain consistency
+  const BlockRestrictable * blk_ptr = dynamic_cast<const BlockRestrictable *>(moose_object);
+  if (blk_ptr && !blk_ptr->isBlockSubset(_variable->activeSubdomains()))
+  {
+    std::string var_ids = Moose::stringify(_variable->activeSubdomains());
+    std::string obj_ids = Moose::stringify(blk_ptr->blockRestricted() ? blk_ptr->blockIDs()
+                                                                      : blk_ptr->meshBlockIDs());
+    mooseError("The 'block' parameter of the object '",
+               moose_object->name(),
+               "' must be a subset of the 'block' parameter of the variable '",
+               variable_name,
+               "':\n    ",
+               moose_object->name(),
+               ": ",
+               obj_ids,
+               "\n    ",
+               variable_name,
+               ": ",
+               var_ids);
+  }
 }
 
 MooseVariableInterface::~MooseVariableInterface() {}

diff --git a/test/tests/dgkernels/dg_block_restrict/2d_dg_diffusion_block_restrict.i b/test/tests/dgkernels/dg_block_restrict/2d_dg_diffusion_block_restrict.i
@@ -80,6 +80,7 @@
   [./norm]
     type = ElementL2Norm
     variable = u
+    block = 1
   [../]
 []
 

diff --git a/test/tests/misc/block_user_object_check/block_check.i b/test/tests/misc/block_user_object_check/block_check.i
@@ -0,0 +1,54 @@
+[Mesh]
+  type = GeneratedMesh
+  dim = 2
+  nx = 10
+  ny = 5
+[]
+
+[MeshModifiers]
+  [./left_block]
+    type = SubdomainBoundingBox
+    block_id = 1
+    bottom_left = '0 0 0'
+    top_right = '0.5 1 0'
+  [../]
+  [./right_block]
+    type = SubdomainBoundingBox
+    block_id = 2
+    bottom_left = '0.5 0 0'
+    top_right = '1 1 0'
+  [../]
+[]
+
+[Variables]
+  [./var_1]
+    block = 1
+    initial_condition = 100
+  [../]
+  [./var_2]
+    block = 2
+    initial_condition = 200
+  [../]
+[]
+
+[Problem]
+  type = FEProblem
+  kernel_coverage_check = true
+  solve = false
+[]
+
+[Executioner]
+  type = Steady
+[]
+
+[Outputs]
+[]
+
+[Postprocessors]
+  [./obj]
+    type = NodalMaxValue
+    variable = var_1
+    #block = 1 # this is what being tested, see the test spec
+    execute_on = 'initial'
+  [../]
+[]
diff --git a/test/tests/misc/block_user_object_check/tests b/test/tests/misc/block_user_object_check/tests
@@ -0,0 +1,18 @@
+[Tests]
+  [./run]
+    type = RunApp
+    input = block_check.i
+    cli_args = 'Postprocessors/obj/block=1'
+  [../]
+  [./error_block_set]
+    type = RunException
+    input = block_check.i
+    cli_args = "Postprocessors/obj/block='1 2'"
+    expect_err = 'must be a subset'
+  [../]
+  [./error_block_any]
+    type = RunException
+    input = block_check.i
+    expect_err = 'must be a subset'
+  [../]
+[]