Merge pull request idaholab#14731 from permcody/race_conditions

Avoiding race conditions
aeslaughter · Feb 18, 2020 · db0c38e · db0c38e
2 parents 48fe948 + eab307c
commit db0c38e
Show file tree

Hide file tree

Showing 9 changed files with 9 additions and 15 deletions.
diff --git a/modules/combined/test/tests/beam_eigenstrain_transfer/tests b/modules/combined/test/tests/beam_eigenstrain_transfer/tests
@@ -19,7 +19,7 @@
     [./error_2]
       type = RunException
       input = 'master_uo_transfer.i'
-      cli_args = "MultiApps/sub/input_files='subapp_err_2.i subapp2_uo_transfer.i' Outputs/csv=false Outputs/exodus=false"
+      cli_args = "MultiApps/sub/input_files='subapp_err_2.i subapp2_uo_transfer.i' Outputs/csv=false Outputs/exodus=false :Outputs/csv=false :Outputs/exodus=false"
       expect_err = 'LineValueSampler: When calling getValue\(\) on LineValueSampler, only one variable can be provided as input to LineValueSampler.'
       method='OPT OPROF' # Test triggers an assert before reaching the expected runtime error
       detail = 'and LineValueSampler shall report an error if multiple variables'
@@ -29,15 +29,15 @@
     [./error_3]
       type = RunException
       input = 'master_uo_transfer.i'
-      cli_args = "MultiApps/sub/input_files='subapp_err_3.i subapp2_uo_transfer.i' Outputs/csv=false Outputs/exodus=false"
+      cli_args = "MultiApps/sub/input_files='subapp_err_3.i subapp2_uo_transfer.i' Outputs/csv=false Outputs/exodus=false :Outputs/csv=false :Outputs/exodus=false"
       expect_err = 'LineValueSampler: When calling getValue\(\) on LineValueSampler, `sort_by` should be set to `id`.'
       detail = 'and LineValueSampler shall report an error if sorting method'
                     ' is not set to `id` when it is used with MultiAppUserObjectTransfer.'
     [../]
     [./error_4]
       type = RunException
       input = 'master_uo_transfer.i'
-      cli_args = "MultiApps/sub/input_files='subapp_err_4.i subapp2_uo_transfer.i' Outputs/csv=false Outputs/exodus=false"
+      cli_args = "MultiApps/sub/input_files='subapp_err_4.i subapp2_uo_transfer.i' Outputs/csv=false Outputs/exodus=false :Outputs/csv=false :Outputs/exodus=false"
       expect_err = 'MultiAppUserObjectTransfer: Point corresponding to master node at'
       detail = 'and LineValueSampler shall report an return value of infinity'
                     ' when the projection of the queried point onto the line'

diff --git a/modules/contact/test/tests/bouncing-block-contact/tied-nodes.i b/modules/contact/test/tests/bouncing-block-contact/tied-nodes.i
@@ -95,7 +95,6 @@
   [exo]
     type = Exodus
   []
-  checkpoint = true
 []
 
 [Preconditioning]

diff --git a/modules/navier_stokes/test/tests/ins/lid_driven/ad_lid_driven_stabilized.i b/modules/navier_stokes/test/tests/ins/lid_driven/ad_lid_driven_stabilized.i
@@ -161,10 +161,6 @@
 [Outputs]
   exodus = true
   file_base = lid_driven_stabilized_out
-  [dofmap]
-    type = DOFMap
-    execute_on = 'initial'
-  []
 []
 
 [Postprocessors]

diff --git a/modules/navier_stokes/test/tests/ins/lid_driven/lid_driven_stabilized.i b/modules/navier_stokes/test/tests/ins/lid_driven/lid_driven_stabilized.i
@@ -156,10 +156,6 @@
 
 [Outputs]
   exodus = true
-  [dofmap]
-    type = DOFMap
-    execute_on = 'initial'
-  []
 []
 
 [Postprocessors]

diff --git a/modules/tensor_mechanics/test/tests/jacobian/cto15.i b/modules/tensor_mechanics/test/tests/jacobian/cto15.i
@@ -406,7 +406,7 @@
 
 
 [Outputs]
-  file_base = cto14
+  file_base = cto15
   exodus = false
   csv = true
 []
diff --git a/modules/tensor_mechanics/test/tests/thermal_expansion/tests b/modules/tensor_mechanics/test/tests/thermal_expansion/tests
@@ -58,7 +58,7 @@
     type = 'PetscJacobianTester'
     input = 'ad_constant_expansion_coeff.i'
     run_sim = 'True'
-    cli_args = 'Outputs/exodus=false Executioner/num_steps=2'
+    cli_args = 'Outputs/exodus=false Outputs/csv=false Executioner/num_steps=2'
     difference_tol = 1e-5
     issues = '#13091'
     design = 'ADComputeThermalExpansionEigenstrain.md'

diff --git a/test/tests/kernels/simple_transient_diffusion/speedtests b/test/tests/kernels/simple_transient_diffusion/speedtests
@@ -8,5 +8,6 @@
         type = SpeedTest
         input = simple_transient_diffusion.i
         cli_args = 'Mesh/nx=100 Mesh/ny=100 Executioner/num_steps=10'
+        prereq = 'trans_diffusion_100x100_t5'
     [../]
 []
diff --git a/test/tests/postprocessors/relative_difference/tests b/test/tests/postprocessors/relative_difference/tests
@@ -17,7 +17,7 @@
       input = 'relative_difference.i'
       csvdiff = 'relative_difference_zero_out.csv'
       cli_args = 'Postprocessors/relative_difference/value2=zero '
-                 'Outputs/out/file_base=relative_difference_zero_out'
+                 'Outputs/out/file_base=relative_difference_zero_out Outputs/file_base=close_to_zero'
 
       detail = 'when values are approximately zero.'
     []

diff --git a/test/tests/vectorpostprocessors/csv_reader/tests b/test/tests/vectorpostprocessors/csv_reader/tests
@@ -17,6 +17,7 @@
     input = read.i
     cli_args = 'UserObjects/tester/rank=1 Outputs/csv=false'
     min_parallel = 2
+    recover = false
 
     requirement = 'The system shall support the ability to read CSV data on only one processor and broadcast it to other ranks.'
   [../]
@@ -26,6 +27,7 @@
     cli_args = "UserObjects/tester/rank=1 UserObjects/tester/gold='1 2 3' Outputs/csv=false"
     min_parallel = 2
     expect_err = "The supplied gold data does not match the VPP data on the given rank."
+    recover = false
 
     requirement = 'The system shall error if the broadcast CSV data does not match on all ranks in a parallel job.'
   [../]