Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: consider all oracles expirations #1397

Merged
merged 1 commit into from
Jun 14, 2023
Merged

fix: consider all oracles expirations #1397

merged 1 commit into from
Jun 14, 2023

Conversation

jyeshe
Copy link
Member

@jyeshe jyeshe commented Jun 14, 2023 •
edited
Loading

refs #1278

@jyeshe jyeshe requested a review from sborrazas June 14, 2023 10:57
@jyeshe jyeshe self-assigned this Jun 14, 2023
sborrazas
sborrazas reviewed Jun 14, 2023
View reviewed changes
Copy link
Contributor

@sborrazas sborrazas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this change include a migration?

@jyeshe
Copy link
Member Author

jyeshe commented Jun 14, 2023 •
edited
Loading

Should this change include a migration?

Reindexation will be required to consider the old_oracles_registered.

@jyeshe jyeshe requested a review from sborrazas June 14, 2023 11:37
@sborrazas
Copy link
Contributor

Should this change include a migration?

Reindexation will be required to consider the old_oracles_registered.

I would imagine there are not that many oracle registrations/expirations, perhaps we can iterate through registrations/expirations and build a count for each generation and then update the total/delta? Similar to how it was done here for example: d965275#diff-6bec92ed38dd3e93f9c2600420a2eca3d0b410d013b67b4621c61cfbfca967f1

@jyeshe
Copy link
Member Author

jyeshe commented Jun 14, 2023

Should this change include a migration?

Reindexation will be required to consider the old_oracles_registered.

I would imagine there are not that many oracle registrations/expirations, perhaps we can iterate through registrations/expirations and build a count for each generation and then update the total/delta? Similar to how it was done here for example: d965275#diff-6bec92ed38dd3e93f9c2600420a2eca3d0b410d013b67b4621c61cfbfca967f1

The issue is that we need to simulate the registrations, registrations of only new oracles and expirations (some are registered and expires multiple times).

@sborrazas
Copy link
Contributor

Should this change include a migration?

Reindexation will be required to consider the old_oracles_registered.

I would imagine there are not that many oracle registrations/expirations, perhaps we can iterate through registrations/expirations and build a count for each generation and then update the total/delta? Similar to how it was done here for example: d965275#diff-6bec92ed38dd3e93f9c2600420a2eca3d0b410d013b67b4621c61cfbfca967f1

The issue is that we need to simulate the registrations, registrations of only new oracles and expirations (some are registered and expires multiple times).

Sounds reasonable. We can then re-sync on the next version to get the right values

@jyeshe jyeshe merged commit 8ed0a7b into master Jun 14, 2023
@jyeshe jyeshe deleted the fix-inactive-oracles-count branch June 14, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sborrazas sborrazas sborrazas approved these changes

Assignees

@jyeshe jyeshe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jyeshe @sborrazas