Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display approximate expiration time for auctions #1403

Merged
merged 2 commits into from
Jun 21, 2023
Merged

feat: display approximate expiration time for auctions #1403

merged 2 commits into from
Jun 21, 2023

Conversation

sborrazas
Copy link
Contributor

refs #1371

@sborrazas sborrazas requested a review from jyeshe June 19, 2023 11:59
@sborrazas sborrazas self-assigned this Jun 19, 2023
jyeshe
jyeshe reviewed Jun 19, 2023
View reviewed changes
Copy link
Member

@jyeshe jyeshe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May we have a test case for an active auction, where the approximate_expire_time is an estimated (different from block's time_in_msecs)?

@sborrazas sborrazas requested a review from jyeshe June 20, 2023 13:39
@sborrazas sborrazas merged commit 208f414 into master Jun 21, 2023
@sborrazas sborrazas deleted the auctions-approx-expiration branch June 21, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyeshe jyeshe jyeshe approved these changes

Assignees

@sborrazas sborrazas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sborrazas @jyeshe