chore: return nil for invalid amount of aex9 holders #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyeshe
force-pushed
the
invalid_aex9_holders_amount
branch
from
d106456
to
751f30b
Compare
sborrazas
reviewed
Jun 20, 2023
| @@ -142,7 +147,7 @@ defmodule AeMdwWeb.AexnView do | |||
| extensions: extensions, | |||
| initial_supply: initial_supply, | |||
| event_supply: event_supply, | |||
| holders: Stats.fetch_aex9_holders_count(state, contract_pk) | |||
| holders: num_holders | |||
There was a problem hiding this comment.
perhaps we can use nil instead, since it would be a bit confusing for it to be either a string or a number
There was a problem hiding this comment.
The purpose is to catch user's attention as much as possible. But we can start with nil documenting it. If it continues to pop up like the balance before I change for NA.
There was a problem hiding this comment.
Actually another thing that would have being useful for a while, is to tag contracts as compliant or not. Opened here: #1410
There was a problem hiding this comment.
Agreed, that would be very useful
jyeshe
changed the title
jyeshe
changed the title
sborrazas
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why
Negative number is confusing for users: #1260 (comment)
Returns nil (for non-applicable) instead.
refs #1257