feat: sync up to latest micro-block #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thepiwo
approved these changes
Jun 17, 2022
jyeshe
reviewed
Jun 21, 2022
| def get_blocks_per_height(from_height, to_height) when is_integer(to_height) do | ||
| {:ok, header} = :aec_chain.get_key_header_by_height(to_height + 1) | ||
|
|
||
| last_mb_hash = :aec_headers.prev_hash(header) |
There was a problem hiding this comment.
There are some "empty" generations (without microblocks).
There was a problem hiding this comment.
this is contemplated by the get_blocks_per_height, mbs will be an empty array
| @@ -163,7 +166,7 @@ defmodule AeMdw.Sync.Server do | |||
|
|
|||
| new_state_data = %__MODULE__{ | |||
| state_data | |||
| | mem_height: State.height(new_db_state), | |||
| | mem_hash: State.height(new_db_state), | |||
There was a problem hiding this comment.
Implement something like State.height_hash ?
There was a problem hiding this comment.
this should have been set to nil, ultimately the result was the same, but mem_hash should have always been either a hash or nil. Fixed now, thanks
jyeshe
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.