chore: add aex9 validation to v1 hash endpoints #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thepiwo
approved these changes
Jul 11, 2022
sborrazas
reviewed
Jul 11, 2022
| balance_for_hash_reply( | ||
| conn, | ||
| contract_pk, | ||
| Validate.id!(account_id, [:account_pubkey]), |
There was a problem hiding this comment.
Perhaps we can start using {:ok, account_pk} <- Validate.id(....) do at the top to stop dealing with both error return values and exception errors?
It would be nice if we only dealt with just one of them, in particular, I think exceptions are very much error prone, so I would like to continue with the functional approach of returning an error tuple. Thoughts?
There was a problem hiding this comment.
I think the exceptions help with deeper propagation but for these validations close to the border I like the idea of refactoring incrementally to use tagged errors.
jyeshe
force-pushed
the
v1-validate-aex9-at-hash
branch
from
311da85
to
94237f0
Compare
sborrazas
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #780