fix: remove blocks cache displayed on /v2/blocks #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was generating invalid results, because blocks were cached too much time. It also provides very little performance benefit (if at all)
jyeshe
reviewed
Jul 13, 2022
There was a problem hiding this comment.
These are integration tests for removal (related to this cache):
1) test blocks it gets uncached generations with range (Integration.AeMdwWeb.BlockControllerTest)
test/integration/ae_mdw_web/controllers/block_controller_test.exs:191
** (ArgumentError) argument error
code: assert is_nil(EtsCache.get(@blocks_table, range_begin))
stacktrace:
(stdlib 3.12.1.2) :ets.lookup(AeMdw.Blocks, 623233)
(ae_mdw 1.14.0) lib/ae_mdw/ets_cache.ex:30: AeMdw.EtsCache.get/2
test/integration/ae_mdw_web/controllers/block_controller_test.exs:206: (test)
.
2) test blocks get a mix of uncached and cached generations with range (Integration.AeMdwWeb.BlockControllerTest)
test/integration/ae_mdw_web/controllers/block_controller_test.exs:211
** (ArgumentError) argument error
code: EtsCache.get(@blocks_table, range_begin)
stacktrace:
(stdlib 3.12.1.2) :ets.lookup(AeMdw.Blocks, 623230)
(ae_mdw 1.14.0) lib/ae_mdw/ets_cache.ex:30: AeMdw.EtsCache.get/2
test/integration/ae_mdw_web/controllers/block_controller_test.exs:229: (test)
.
Finished in 6.6 seconds
18 tests, 2 failures
thepiwo
approved these changes
Jul 13, 2022
jyeshe
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was generating invalid results, because blocks were cached too much time.
It also provides very little performance benefit (if at all)