feat: allow filtering transactions count by scope #798
Conversation
lib/ae_mdw/txs.ex
Outdated
| do: {:ok, DbUtil.gen_to_txi(state, last_gen + 1) - DbUtil.gen_to_txi(state, first_gen)} | ||
|
|
||
| def count(_state, _range, _params), | ||
| do: {:error, ErrInput.Query.exception(value: "can't query by multiple values")} |
There was a problem hiding this comment.
It matched with unknown params like ?gen=1-100
There was a problem hiding this comment.
You're right, changing the error message
|
|
||
| assert 101 = | ||
| conn | ||
| |> get("/txs/count", scope: "txi:#{first_txi}-#{last_txi}") |
There was a problem hiding this comment.
We could start using a shorthand for scopes like:
http://localhost:4000/txs/count?gen=5:40 instead of (scope=gen:5-40)
What you think?
There was a problem hiding this comment.
I would rather not introduce two different ways of doing the same thing, this adds complexity to the API. I also think scope filtering (either txi or gen) should be done with a single parameter, this makes it clear to the user what scoping means and makes it impossible to filter by two different things (e.g. what happens when ?gen=0-10&txi=20-30)
We should also revisit this matter once we get rid of txis from the API entirely
There was a problem hiding this comment.
I think it would be good for the user to allow also the shorthand but it would be an improvement. When both params are used there would be an error handling similar to the one that there was on line 64:
do: {:error, ErrInput.Query.exception(value: "can't query by multiple values")}
sborrazas
force-pushed
the
tx-count-scope
branch
from
b2ecba8
to
5cbb64f
Compare
sborrazas
force-pushed
the
tx-count-scope
branch
from
5cbb64f
to
ffa2bf8
Compare
refs #752