feat: log open/closed channels together with their locked AE #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thepiwo
reviewed
Aug 14, 2022
jyeshe
approved these changes
Aug 15, 2022
Comment on lines
+23
to
+33
| @spec close_mutation(closing_type(), Node.aetx()) :: ChannelCloseMutation.t() | ||
| def close_mutation(tx_type, tx), do: ChannelCloseMutation.new(tx_type, tx) | ||
|
|
||
| @spec open_mutation(Node.aetx()) :: ChannelOpenMutation.t() | ||
| def open_mutation(tx), do: ChannelOpenMutation.new(tx) | ||
|
|
||
| @spec deposit_mutation(Node.aetx()) :: ChannelSpendMutation.t() | ||
| def deposit_mutation(tx), do: ChannelSpendMutation.new(:aesc_deposit_tx.amount(tx)) | ||
|
|
||
| @spec withdraw_mutation(Node.aetx()) :: ChannelSpendMutation.t() | ||
| def withdraw_mutation(tx), do: ChannelSpendMutation.new(-:aesc_withdraw_tx.amount(tx)) |
There was a problem hiding this comment.
It's neat but personally I would call the new directly avoiding the indirection as they are used only once.
There was a problem hiding this comment.
The purpose of this was to encapsulate the :aesc module inside the Channels module so that the Transaction module didn't have to deal with them directly
This migration will avoid requiring a full-sync, but it will take ~30mins to run.
|
@thepiwo I've now added the migration which to me took ~30min to run. This migration will avoid having to perform a resync |
thepiwo
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #748