feat: index miners count and total rewards from fees #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes a migration that takes 15-30mins to index the already processed generation miners.
sborrazas
force-pushed
the
miners-index
branch
from
073a65c
to
26702d1
Compare
sborrazas
changed the title
The reason for this is that miner's pks always change, so for every new key block there will almost always be a new miner.
thepiwo
approved these changes
Aug 23, 2022
jyeshe
reviewed
Aug 24, 2022
Comment on lines
25
to
36
| case State.get(state, Model.Miner, beneficiary_pk) do | ||
| {:ok, Model.miner(total_reward: old_reward) = miner} -> | ||
| {State.put(state, Model.Miner, Model.miner(miner, total_reward: old_reward + reward)), | ||
| false} | ||
|
|
||
| :not_found -> | ||
| {State.put( | ||
| state, | ||
| Model.Miner, | ||
| Model.miner(index: beneficiary_pk, total_reward: reward) | ||
| ), true} | ||
| end |
There was a problem hiding this comment.
It's already readable but might convey the idea at a glance by giving a name to this case block with a function (sth like increment_total_reward)
Comment on lines
39
to
45
| State.update(state, Model.Stat, Stats.miners_count_key(), fn | ||
| Model.stat(payload: count) = stat -> | ||
| Model.stat(stat, payload: count + 1) | ||
|
|
||
| nil -> | ||
| Model.stat(index: Stats.miners_count_key(), payload: 1) | ||
| end) |
There was a problem hiding this comment.
same here with increment_payload
| def fetch_miner!(state, miner_pk), | ||
| do: render_miner(State.fetch!(state, Model.Miner, miner_pk)) | ||
|
|
||
| defp build_streamer(state, cursor), do: &Collection.stream(state, Model.Miner, &1, nil, cursor) |
| def run(_from_start?) do | ||
| state = State.new() | ||
|
|
||
| case state |> Collection.stream(Model.DeltaStat, :backward, nil, nil) |> Enum.take(1) do |
jyeshe
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #844
Includes a migration that takes 15-30mins to index the already processed generation miners.