Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: index channels and add active channels endpoint #889

Merged
merged 5 commits into from
Sep 7, 2022
Merged

feat: index channels and add active channels endpoint #889

merged 5 commits into from
Sep 7, 2022

Conversation

sborrazas
Copy link
Contributor

Displays the information in the "State Channels" table from #823

@sborrazas sborrazas self-assigned this Sep 2, 2022
jyeshe
jyeshe requested changes Sep 5, 2022
View reviewed changes
Copy link
Member

@jyeshe jyeshe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be important to add unit tests for syncing (mutations) and endpoint.

lib/ae_mdw/channels.ex Outdated Show resolved Hide resolved
lib/ae_mdw/channels.ex Outdated Show resolved Hide resolved
lib/ae_mdw/channels.ex Outdated Show resolved Hide resolved
lib/ae_mdw/channels.ex Outdated Show resolved Hide resolved
lib/ae_mdw/db/mutations/channel_open_mutation.ex Outdated Show resolved Hide resolved
priv/migrations/20220901120000_add_active_channels.ex Outdated Show resolved Hide resolved
jyeshe
jyeshe reviewed Sep 6, 2022
View reviewed changes
lib/ae_mdw/channels.ex Outdated Show resolved Hide resolved
jyeshe
jyeshe requested changes Sep 6, 2022
View reviewed changes
Copy link
Member

@jyeshe jyeshe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got this requesting /v2/channels:

Screenshot from 2022-09-06 23-19-09

Please add some kind of automated test.

@sborrazas
Copy link
Contributor Author

@jyeshe done! added tests cases a well, sorry about that!

jyeshe
jyeshe approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@jyeshe jyeshe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sborrazas sborrazas merged commit d86b1cc into master Sep 7, 2022
@sborrazas sborrazas deleted the active-channels branch September 7, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyeshe jyeshe jyeshe approved these changes

@thepiwo thepiwo thepiwo approved these changes

Assignees

@sborrazas sborrazas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sborrazas @thepiwo @jyeshe