Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create nft ownership based on Mint event #897

Merged
merged 2 commits into from
Sep 12, 2022
Merged

feat: create nft ownership based on Mint event #897

merged 2 commits into from
Sep 12, 2022

Conversation

jyeshe
Copy link
Member

@jyeshe jyeshe commented Sep 8, 2022

Refs #629

@marc0olo
Copy link

marc0olo commented Sep 8, 2022

@jyeshe you're already preparing for upcoming changes, right? just wondering :)

@jyeshe
Copy link
Member Author

jyeshe commented Sep 9, 2022

@jyeshe you're already preparing for upcoming changes, right? just wondering :)

yes Marco, it's related to previpus PR so better get it done. Transfers continue to be independent from minting (not required before transfer). I've left the validations up to the contracts for both mint and transfer operations.

@jyeshe
Copy link
Member Author

jyeshe commented Sep 9, 2022

Later we could have a feature related to contract verification that flags it if it doesn't comply to the standard.

@jyeshe jyeshe merged commit 929e7c5 into master Sep 12, 2022
@jyeshe jyeshe deleted the nft-mint branch September 12, 2022 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants