-
Notifications
You must be signed in to change notification settings - Fork 5
AEX-2 Compatibility #98
base: aex-2
Are you sure you want to change the base?
Conversation
package.json
Outdated
@@ -22,20 +22,21 @@ | |||
"dependencies": { | |||
"@aeternity/aepp-components": "git+https://github.com/aeternity/aepp-components.git#develop", | |||
"@aeternity/aepp-components-3": "3.0.0-alpha.9", | |||
"@aeternity/aepp-sdk": "6.0.0", | |||
"@aeternity/aepp-sdk": "github:aeternity/aepp-sdk-js#aex-2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This branch is not up-to date with the Lima release and results in Unable to connect to choosen node
error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the new changes working with the branch of the pull request to the sdk that supports aex-2 (aeternity/aepp-sdk-js#512)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are working with fork of the sdk aex-2 branch. The only difference is changed node version because i was not able to connect to the testnet -> https://github.com/petbaik/aepp-sdk-js/blob/feature/aex-2/es/node.js#L158
"@aeternity/aepp-sdk": "github:petbaik/aepp-sdk-js#feature/aex-2"
The only difference between sdk aex-2 branch and my fork is the changed node version
After a discussion with the SDK team, we agreed that the AEX-2 functionality will be merged in the master branch after it is being So we put this on hold until then. |
Is going to be included in v7.0.0 major release of the sdk-js. |
Merged. Ref. aeternity/aepp-sdk-js@e7e9eb4 |
Ref. implementation here: https://github.com/aeternity/aepp-sdk-js/tree/develop/examples/browser/extension |
…DK's AEX-2 implementation
The object initialized in aepp is still called RpcAepp. The aepps created so far still will not be compatible with the extension unless they use RpcAepp. |
After investigating this I came to the conclusion we cannot use wildcard matches for the externally connectable, so what you've proposed with the content script in the middle is a good approach and maybe the only feasible one at this point in time. Together with @nduchak we discussed that and we think we can remove the |
Transfer changes made for Aex-2 from pr aeternity#98
Aex-2 communication can be tested with this aepp -> http://aex2.aepps.tech/
There are several things that I saw while integrating sdk-s
RpcWallet
andRpcAepp
that are connected to the sdk implementation of aex-2 (aeternity/aepp-sdk-js#512)chrome.runtime.connect
method inside the aepp. This method will connect to the extension only if the domain of the aepp is specified in manifest.json of the extension (https://developer.chrome.com/apps/manifest/externally_connectable). I think content script should be in the middle of the aepp and the extension. This way it will work no matter what is the domain of the aeppRpcAepp
. I think the object should be calledAepp
and get the properties of theRpcAepp
if extension wallet is available. Because now when I run the example aepp app it doesnt work with base aepp because the aepp initializeRpcAepp
object and not anAepp
object. Another thing is that when you initiateRpcAepp
object you need to specify network, I think the network should be retrieved from the wallet extensiondevelop
.