Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Wallet): Use postMessage for communication with extension wall… #815

Merged
merged 28 commits into from
Dec 17, 2019

Conversation

nduchak
Copy link
Contributor

@nduchak nduchak commented Dec 8, 2019

…et through Content Script(bridge between page and extension)

Adjust example extension

…et through `Content Script`(bridge between page and extension)

Adjust example extension
@nduchak nduchak added this to the 7.0.0 milestone Dec 8, 2019
@nduchak nduchak self-assigned this Dec 8, 2019
@lgtm-com
Copy link

lgtm-com bot commented Dec 8, 2019

This pull request introduces 1 alert when merging 9b8b01a into 5b94cb1 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

…xtension and origin from connection for iframe wallet
…extension' into feat/switch-to-post-message-for-extension
@lgtm-com
Copy link

lgtm-com bot commented Dec 9, 2019

This pull request introduces 1 alert when merging 7b067f4 into 5b94cb1 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

… type, data }` where is type is direction `to_aepp, to_waellet`. This was done because the message contain the same `origin`
@lgtm-com
Copy link

lgtm-com bot commented Dec 9, 2019

This pull request introduces 1 alert when merging 4b06038 into 5b94cb1 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@nduchak nduchak force-pushed the feat/switch-to-post-message-for-extension branch from 2bdd806 to 0dbd594 Compare December 11, 2019 14:56
@codecov
Copy link

codecov bot commented Dec 11, 2019

Codecov Report

Merging #815 into develop will decrease coverage by 0.21%.
The diff coverage is 18.55%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #815      +/-   ##
===========================================
- Coverage    81.51%   81.29%   -0.22%     
===========================================
  Files           55       55              
  Lines         2792     2802      +10     
===========================================
+ Hits          2276     2278       +2     
- Misses         516      524       +8
Impacted Files Coverage Δ
es/ae/index.js 100% <ø> (ø) ⬆️
es/ae/contract.js 96.42% <100%> (ø) ⬆️
es/utils/aepp-wallet-communication/schema.js 61.11% <100%> (+2.28%) ⬆️
es/utils/aepp-wallet-communication/helpers.js 33.33% <23.07%> (-7.85%) ⬇️
.../utils/aepp-wallet-communication/rpc/wallet-rpc.js 16.09% <33.33%> (-0.58%) ⬇️
es/utils/aepp-wallet-communication/rpc/aepp-rpc.js 22.22% <45.45%> (-1.31%) ⬇️
...utils/aepp-wallet-communication/rpc/rpc-clients.js 9.23% <9.23%> (ø)
es/channel/handlers.js 79.27% <0%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef895ee...e7acd95. Read the comment docs.

@nduchak nduchak merged commit dc7b4c2 into develop Dec 17, 2019
@nduchak nduchak mentioned this pull request Dec 18, 2019
@nduchak nduchak deleted the feat/switch-to-post-message-for-extension branch January 2, 2020 16:25
@mradkov mradkov mentioned this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants