Account activities tab

[michele-franchi]

Columns:

• Hash: in some cases we won’t have any tx-hash, e.g. AENS expiration won’t have any tx-hash, the same for Beneficiary reward
• Date
• Type
• Activity
• Data

Type	Activity	Data	Technical considerations
AE	Transferred toReceived fromBeneficiary reward	ak_… + Æ amountak_… + Æ amountÆ amount	how to deal with SH-DEX activities to avoid duplications?
AENS	ClaimedExpiredRevokedReceived fromTransferred to	xyz.chainxyz.chainxyz.chainak_… + xyz.chainak_… + xyz.chain
AEX-9	Token createdTransferred toReceived fromMint receivedBurned	TOKEN_SYMBOLak_… + TOKEN_SYMBOL & amountak_… + TOKEN_SYMBOL & amountTOKEN_SYMBOL & amountTOKEN_SYMBOL & amount	how to deal with SH-DEX activities to avoid duplications?can we distinguish transfers, mints and burns?
AEX-141	Collection createdTransferred toReceived fromMint receivedBurned	COLLECTION_NAMEak_… + COLLECTION_NAME & nft_idak_… + COLLECTION_NAME & nft_idCOLLECTION_NAME & nft_idCOLLECTION_NAME & nft_id	can we distinguish transfers, mints and burns?
SH-DEX(to be checked)	SwappedAdded liquidityRemoved liquidity	TOKEN_SYMBOL & amount ↔︎ TOKEN_SYMBOL & amountTOKEN_SYMBOL & amount +TOKEN_SYMBOL & amount ↔︎ POOL_SYMBOL & amountPOOL_SYMBOL ↔︎ TOKEN_SYMBOL & amount + TOKEN_SYMBOL & amount	see AE and AEX-9 comments, avoid duplicated outputmaybe we need to include that in the type “AEX-9” and cannot have it separately in SH-DEX as type
?	?	?	?

Endpoint: GET /v2/accounts/:id/activities

[marc0olo]

@lukeromanowicz @michele-franchi I just provide the screenshot here for better readability:

[lukeromanowicz]

@marc0olo would you be able to provide accounts where the mentioned activities happened? Especially those AEX-9, AEX-141 and SH-DEX are hard to find

Edit: SH-DEX is covered

[lukeromanowicz]

Looks like we need to simplify Contract-related fields due to insufficient information available in mdw. Here is a mdw issue to track:
aeternity/ae_mdw#1497

[lukeromanowicz]

Another (non-blocking) related issue that has been reported: aeternity/ae_mdw#1498

[davidyuk]

the same for Beneficiary reward

the block hash may be used instead. Also, consider showing reward transfers to BRI account.

[marc0olo]

the block hash may be used instead

if we do that I would prefer to include the block hash in "data" column 😅

Also, consider showing reward transfers to BRI account.

yes, absolutely! but this is only relevant for one specific account IMO (or in the future for another BRI account in case that changes) @michele-franchi

[lukeromanowicz]

I checked again the state of things and it looks like the issue is mostly unblocked with a few limitations:

• it's not possible to implement events count for pagination information - Mdw team doesn't plan to implement an endpoint providing that information - Activities Count endpoint ae_mdw#1506
• it's not possible to tell what ContractCallTxEvent is referring to (aex-n tokens, dex or something else). You can though take a wild guess based on the name of the contract call endpoint e.g. calls to these endpoints are most likely related to superhero dex unless somebody created custom contracts with the same endpoint names

export const SWAP_CONTRACT_CALLS = [
  'swap_exact_tokens_for_tokens',
  'swap_tokens_for_exact_tokens',
  'swap_exact_ae_for_tokens',
  'swap_tokens_for_exact_ae',
  'swap_exact_tokens_for_ae',
  'swap_ae_for_exact_tokens',
]
export const ADD_LIQUIDITY_CONTRACT_CALLS = [
  'add_liquidity',
  'add_liquidity_ae',
]
export const REMOVE_LIQUIDITY_CONTRACT_CALLS = [
  'remove_liquidity',
  'remove_liquidity_ae',
]

• It's not possible to deduplicate events because it affects pagination capabilities. For instance, you will see:

- [th_aaaaaaaaaaaaaa            Internal Transfer                       (2 AE)]
- [th_aaaaaaaaaaaaaa            Name Claim                mynewname.chain (2 AE)]

Everything else (transfers of AEX-9 and AEX-141) at first glance can now be easily presented to the user as proposed in the designs. The only difference is that we might need to alter the activity name slightly.

[michele-franchi]

DEX contract: https://github.com/aeternity/dex-contracts-v2#on-mainnet