Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AEX-2: Drop identifiers #29

Closed
davidyuk opened this issue May 20, 2019 · 6 comments
Closed

AEX-2: Drop identifiers #29

davidyuk opened this issue May 20, 2019 · 6 comments

Comments

@davidyuk
Copy link
Member

Some transports like postMessage interface provide own identification mechanisms. That in the case of postMessage interface (origin field) even more secure that proposed solution, because of the origin field provided by a browser so can't be faked. This makes reasonable to make identifiers proposed by AEX-2 optional.

@shekhar-shubhendu
Copy link
Contributor

Using different identifiers for different transport layer will break the uniformity and will be difficult to manage.

@davidyuk
Copy link
Member Author

It means that AEX-2 trying to handle too much, let's make it simpler. We shouldn't ignore features with greater security because of our universal standards. Maybe we can extract identification into a separate standard and apply when it is necessary?

@shekhar-shubhendu
Copy link
Contributor

AEX-2 is adding an identifier but you can always use the features provided by the postMessage API(or any transport layer) alongside it. I don't see how adding the identifier will break it.

@davidyuk
Copy link
Member Author

davidyuk commented Jun 4, 2019

#40 (comment) probably proves that identifiers are not needed at all or they should be reimplemented

@davidyuk davidyuk changed the title AEX-2: Make identifiers optional AEX-2: Drop identifiers Jun 5, 2019
@davidyuk
Copy link
Member Author

davidyuk commented Jun 5, 2019

Defining the transport layer incl. connection set up between wallet and aepp is currently out of scope and will not be added to the AEX. #40 (comment)

I was thinking that identifiers are made for one of the cases from #40. If it is "out of scope", then I can't find any reasoning for identification mechanics and proposing to drop it.

@davidyuk
Copy link
Member Author

Solved in #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants