Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain GAs in State Channel FSM #367

Merged
merged 6 commits into from
Jul 16, 2019

Conversation

velzevur
Copy link
Member

Changes corresponding to aeternity/aeternity#2502

lucafavatella
lucafavatella previously approved these changes Jun 18, 2019
knarz
knarz previously approved these changes Jun 19, 2019
Copy link
Contributor

@lucafavatella lucafavatella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking back approval as not planned for this release.

@velzevur velzevur force-pushed the PT-165413555_FSM_GA_awareness-rebased branch from b9ca68e to c0bc2e8 Compare July 3, 2019 09:23
channels/ON-CHAIN.md Outdated Show resolved Hide resolved
channels/ON-CHAIN.md Outdated Show resolved Hide resolved
channels/authentication.md Outdated Show resolved Hide resolved
* `parallel` - when order is irrelevant to the validation process and checks
can be performed in a concurrent manner.

For `basic` authentication always `sequential` behavior is used.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really true... If either signature is wrong it will fail in the same call to verify - I think it is simpler to just call it parallel.

channels/authentication.md Outdated Show resolved Hide resolved
velzevur and others added 5 commits July 3, 2019 13:27
Co-Authored-By: Hans Svensson <hanssv@gmail.com>
Co-Authored-By: Hans Svensson <hanssv@gmail.com>
Co-Authored-By: Hans Svensson <hanssv@gmail.com>
Co-Authored-By: Hans Svensson <hanssv@gmail.com>
@velzevur velzevur merged commit 3a7b1bd into master Jul 16, 2019
@velzevur velzevur deleted the PT-165413555_FSM_GA_awareness-rebased branch July 16, 2019 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants