Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify valid target for node-sass peer dep. #2

Closed
wants to merge 1 commit into from

Conversation

danpaz
Copy link

@danpaz danpaz commented Apr 10, 2015

By specifying node-sass with a caret ^3.0.0 this package fails to install as a peer dependency. I don't think npm recognizes 3.0.0-beta* as being ^3.0.0. Here's what I saw:

$ npm i
npm ERR! Darwin 14.1.0
npm ERR! argv "node" "/Users/danielpazsoldan/.nvm/v0.10.33/bin/npm" "i"
npm ERR! node v0.10.33
npm ERR! npm  v2.5.1
npm ERR! code ETARGET

npm ERR! notarget No compatible version found: node-sass@'>=3.0.0 <4.0.0'
npm ERR! notarget Valid install targets:
npm ERR! notarget ["0.9.4-rc1","0.2.0","0.2.1","0.2.2","0.2.3","0.2.4","0.2.5","0.2.6","0.3.0","0.4.0","0.4.1","0.4.2","0.4.3","0.4.4","0.5.0","0.5.1","0.5.2","0.5.3","0.5.4","0.6.0","0.6.1","0.6.2","0.6.3","0.6.4","0.6.5","0.6.6","0.6.7","0.7.0-alpha","0.7.0","0.8.0","0.8.1","0.8.2","0.8.3","0.8.4","0.8.5","0.8.6","0.9.0","0.9.1","0.9.2","0.9.3","0.9.4-rc1","0.9.4","0.9.5-rc1","0.9.5","0.9.6","1.0.0","1.0.1","1.0.2-alpha","1.0.2","1.0.3","1.1.0","1.1.1","1.1.2","1.1.3","1.1.4","1.2.0","1.2.1","1.2.2","1.2.3","2.0.0-beta","2.0.0","2.0.1","3.0.0-alpha.0","3.0.0-beta.2","3.0.0-beta.3","3.0.0-beta.4","2.1.0","2.1.1","3.0.0-beta.5"]

Specifying the exact 3.0.0-beta version seems to fix the problem. I wasn't sure which version you wanted so I just picked the latest 3.0.0-beta.5.

@d6u
Copy link

d6u commented Apr 10, 2015

👍

1 similar comment
@TayHobbs
Copy link

+1

@BrianBravo
Copy link

+1

@simonexmachina
Copy link
Collaborator

Ah rats! And the reason this worked for me is exactly the reason why they're talking about deprecating peerDependencies.

Thanks for the PR, but we want to specify the minimum version in the package.json to allow people to downgrade if they don't want the latest beta, so the dependency should be 1.0.0-beta. I've pushed v1.0.0-beta.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants