Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What are the breaking changes with version 4.x? #63

Closed
rmehner opened this issue Aug 29, 2017 · 5 comments
Closed

What are the breaking changes with version 4.x? #63

rmehner opened this issue Aug 29, 2017 · 5 comments

Comments

@rmehner
Copy link

rmehner commented Aug 29, 2017

Hey there,

I see that you've pushed out a new envalid version 4.x. We currently depend on 3.x and wonder what the breaking changes are for that new major version and what we need to do to migrate to that version. So far I can't really find anything and there's also no changelog or release notes on the GitHub release.

Would be super nice if you could clarify, so we can start migrating :)

Thank you so much for all you work so far and have a great day!

@SimenB
Copy link
Collaborator

SimenB commented Aug 29, 2017

There's a breaking change if you use strict mode. Details in the readme: https://github.com/af/envalid/blob/937f13d8babc576e2a3215280ffbb7c71486c1b1/README.md#strict-mode (tl;dr - it's immutable now, and throws if you try to access vars not there)
Technically also a breaking change if you manually specified undefined as a default, it's now allowed instead of throwing.

We should just add a changelog...

@rmehner
Copy link
Author

rmehner commented Aug 29, 2017

Thank you for the clarification @SimenB!

Changelog would be super nice 👍

@af
Copy link
Owner

af commented Aug 29, 2017

Sorry about this @rmehner, I meant to put the change data on the github Release but it slipped my mind! I'll try and do that today. I may even write a blog post with some usage examples. As Simen mentioned the strict mode change is the only breaking change

@rmehner
Copy link
Author

rmehner commented Aug 29, 2017

No worries @af, things like that happen :)

@af
Copy link
Owner

af commented Aug 29, 2017

The releases page is now updated. Thanks for the reminder!

@af af closed this as completed Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants