You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
As this was already a recursive commit, I wonder should we keep the "Parse... and try to parse it."? Funnier to keep it this way. If not I would suggest : "Extract code portions from markdown and try to parse it"
bed8525
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. FYI we have a test on it: https://github.com/AF83/readminator/blob/master/test/readminator_test.rb#L8
bed8525
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this was already a recursive commit, I wonder should we keep the "Parse... and try to parse it."? Funnier to keep it this way. If not I would suggest : "Extract code portions from markdown and try to parse it"
bed8525
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 6d3c668.