Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metricExchange.Monitor and poolMetrics.Monitor goroutine leak #95

Open
foobatman opened this issue Sep 12, 2018 · 0 comments
Open

metricExchange.Monitor and poolMetrics.Monitor goroutine leak #95

foobatman opened this issue Sep 12, 2018 · 0 comments

Comments

@foobatman
Copy link

We are seeing a pattern which indicates a likely goroutine leak. When there are downstream errors and circuit is opened for any given command, then after a while lot of goroutines get created and never closed ( pprof output attached ). A quick glance at the code suggests that they are created for every command's CircuitBreaker. But we ran few test where only single command is used, still the goroutine count created by metricExchange.Monitor and poolMetrics.Monitor seemed to be increasing according to the pprof output.

##Test environment:

We ran around 100 RPM, no failure ( i.e. circuit was never opened ), the expectation was that it will have constant number of go-routines created by hystrix-go lib metricExchange.Monitor and poolMetrics.Monitor. But as it can be seen in the output, the number increased.

pprof output before running the test:

Before running test

pprof output after running the test:

After running test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant