Add IO functions #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- assign reviewers (currently only kaitj and tkkuehn, can add more) - bump_version for semantic versioning - release to publish to pypi - test for linting and unit testing
- add .gitignore and update to ignore test generated files - add necessary libraries for working with afids - add test task to poe - setup type hints for functions - create exceptions.py to hold custom exceptions - create io.py for handling input/output methods - add dummy data (valid fcsv file, small nifti) - look into generating images in the future (look at nibabel for possible solutions?)
- take advantage of commit to fix spacing in PR template
kaitj
force-pushed
the
enh/io_functions
branch
4 times, most recently
from
55a1f03
to
2e40e20
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 3
Lines ? 83
Branches ? 0
========================================
Hits ? 83
Misses ? 0
Partials ? 0
|
- add step to install package - save report as xml file in the workflow runner - add gha to post coverage report
|
This should be good for a first look. Still missing a few methods, but wanted to get something in so that we can configure the coverage as we want. It's currently set with a 5% threshold (e.g. it should fail if coverage falls below 95% - I think this is overall and not individual components but I might be wrong). |
tkkuehn
requested changes
Jun 13, 2023
- Renamed AFIDS_FIELDNAMES -> FCSV_FIELDNAMES - Update 'id' column fieldname to match slicer header - Use `usecols` in read_csv call - Change afid_coords from a numpy array to a composite strategy using hypothesis.extra.numpy.array - rm assignment of get_afid in test_invalid_num_get_afid - rm load_nii function and normalization (can use other packages like sklearn for this) - added fcsv template as static file under resources that can be imported rather than called in function
tkkuehn
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds methods and tests for reading/writing nifti files and afids-associated files.
In addition, took advantage of this branch to make a minor change to the PR template to fix spacing.
Note: This is also being used as a test for
CodecovTypes of changes
What types of changes does your code introduce? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!poe qualitytaskNotes
All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.