Fix regression opening textures modal introduced with the React upgra…

…de in #647
aframevr · Dec 24, 2022 · 756c072 · 756c072
1 parent 3b3ac22
commit 756c072
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/components/modals/ModalTextures.js b/src/components/modals/ModalTextures.js
@@ -71,17 +71,17 @@ export default class ModalTextures extends React.Component {
     this.generateFromAssets();
   }
 
-  componentDidUpdate() {
+  componentDidUpdate(prevProps) {
     if (this.state.isOpen && !AFRAME.INSPECTOR.assetsLoader.hasLoaded) {
       AFRAME.INSPECTOR.assetsLoader.load();
     }
+    if (this.state.isOpen && this.state.isOpen !== prevProps.isOpen) {
+      this.generateFromAssets();
+    }
   }
 
   static getDerivedStateFromProps(props, state) {
     if (state.isOpen !== props.isOpen) {
-      if (props.isOpen) {
-        this.generateFromAssets();
-      }
       return { isOpen: props.isOpen };
     }
     return null;