-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all dependencies and fix react code warnings #647
Update all dependencies and fix react code warnings #647
Conversation
gm, invariant, object-assign, react-file-reader-input, eslint-plugin-promise, postcss-import were unused dependencies |
1c03151
to
40c0058
Compare
I rebased and push forced to add the fixes from #648
|
40c0058
to
76a507d
Compare
Copy html to clipboard and opening the textures modal doesn't work. I'll look into it later. |
76a507d
to
90d69ea
Compare
includes the fix for #638 (comment) |
Now using GLTFExporter directly from three package instead of the old one in vendor folder. |
7afccb9
to
889df27
Compare
This needs rebase |
889df27
to
c2b7a6f
Compare
Is it possible to break this down in smaller PRs? |
c2b7a6f
to
8debe15
Compare
Now that all the other PRs are merged, this one contains only the big update of react and all dependencies. I could split the last commit in its own PR where I add husky but currently it depends on another commit that changes package-lock.json, that would be a headache to merge this commit first then rebase this PR. I can separate it when I'm done fixing the regression with the clipboard. |
38k lines the package-lock.json file? Is not that a bit crazy 😄? Can it be purged / simplified? Adds tons of noise |
Ah ah no it can't be simplified, we need to commit the file as is. |
Thanks for merging, I'll fix the two remaining todos #662 asap. |
Update all dependencies and fix react code warnings
This closes #641 and #601
Remaining todos: