Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete aframe.js (ancient & unused copy of code from 0.4.0) #691

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

diarmidmackenzie
Copy link
Contributor

Following on from aframevr/aframe#5333 and based on comments from @vincentfretin, I checked aframe-inspector for any usage of 'https://cdn.aframe.io'.

The only instances I found were in the module examples\js\aframe.js.

This appears to be a copy of the 0.4.0 distribution of A-Frame, and not used by any of the examples. I believe it can be deleted, and it would be good housekeeping to do so.

Hence this PR.

Copy link
Contributor

@vincentfretin vincentfretin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes indeed.

@vincentfretin
Copy link
Contributor

The list of textures images I talked about in comment aframevr/aframe#5119 (comment) is retrieved via https://aframe.io/sample-assets/dist/images.json when you open the texture modal.
The url is defined here

const assetsBaseUrl = 'https://aframe.io/sample-assets/';
but that's different from https://cdn.aframe.io/ so you can't use AFRAME_ROOT_CDN here. If we introduce another configurable constant, that can be done in another PR. But also this feature should maybe be dropped completely, see #676

@vincentfretin
Copy link
Contributor

For my comment above, I created #702

@dmarcos this PR just remove an unused file, you can merge.

@dmarcos
Copy link
Member

dmarcos commented Dec 7, 2023

Thanks!

@dmarcos dmarcos merged commit 5d73d6c into aframevr:master Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants