[cleanup] Remove dead code in several React components #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentfretin
commented
Aug 16, 2024
| if (this.props.onChange) { | ||
| this.props.onChange(entity); | ||
| } | ||
| Events.emit('entityselect', entity, true); |
There was a problem hiding this comment.
This true param here has no meaning, there is no second parameter in any of the entityselect listener in the code base, meaning there is no Events.on('entityselect', (entity, someboolean) => ...
vincentfretin
force-pushed
the
cleanup-scenegraph
branch
from
3e9181f
to
85c6d46
Compare
vincentfretin
changed the title
vincentfretin
changed the title
|
Thanks! |
vincentfretin
force-pushed
the
cleanup-scenegraph
branch
from
0d8871b
to
1391cd5
Compare
|
I rebased to fix the conflict. You can merge. |
|
@dmarcos in case you missed my comment. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those are props and state that aren't used anywhere.