You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this change breaks removestate. removestate expects is to return the index of the state, or false if it doesn't exist. After this change, removestate does is not able to remove the proper state because it doesn't know its index. I opened #1107 to track this issue.
4699078
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ngokevin,
I think this change breaks
removestate
.removestate
expectsis
to return the index of the state, or false if it doesn't exist. After this change,removestate
does is not able to remove the proper state because it doesn't know its index. I opened #1107 to track this issue.4699078
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drryanjames good catch!