Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a-entity.js: removestate not working properly #1107

Closed
CodeRhymesLife opened this issue Mar 8, 2016 · 2 comments
Closed

a-entity.js: removestate not working properly #1107

CodeRhymesLife opened this issue Mar 8, 2016 · 2 comments
Assignees

Comments

@CodeRhymesLife
Copy link

a-entity's removestate expects is to return the index of the state it's searching for (or false if not found). Change 4699078 updated is to return true if the state is found rather than the state's index, which breaks removestate. Now, removestate does not remove the correct state if the state exists.

I think the fix here is to revert 4699078.

This issue effects the cursor's hover functionality, and likely other important scenarios that rely on state changes.

@ngokevin
Copy link
Member

ngokevin commented Mar 8, 2016

Not to revert that, but to have removeState look up the index.

Better to return true because index 0 should be a truthy case.

@dmarcos
Copy link
Member

dmarcos commented Mar 9, 2016

Fixed in #1115

@dmarcos dmarcos closed this as completed Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants