-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simple fix for Gear VR and Oculus Touch controller issues (fixes #3447 and #3483) #3489
simple fix for Gear VR and Oculus Touch controller issues (fixes #3447 and #3483) #3489
Conversation
src/utils/tracked-controls.js
Outdated
if (prefix && controller.id.indexOf(prefix) === -1) { matches = true; } | ||
for (var j = 0; j < filterIdPrefixes.length; j++) { | ||
var prefix = filterIdPrefixes[j]; | ||
console.log(prefix, ' ?= ', controller.id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't need log
0da2044
to
5998faf
Compare
src/utils/tracked-controls.js
Outdated
|
||
function splitOnPipeOnce (stringToSplit) { | ||
var rtn = splitOnPipeMap[stringToSplit]; | ||
if (!rtn) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Early return if (rtn) { return; }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I'm not sure it actually looks better now, but I understand your stylistic preference.)
5998faf
to
6ada9d4
Compare
all good now I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's define/pass the prefixes as an array always, we don't really need to keep it in a string.
The prefix also needs to be passed into tracked-controls, not sure that will survive as array...? |
If we don't mind doing the split each time, can remove the split once map stuff and it will look much more like what is in there now, just not broken. Is that preferable? |
Have "put the candle back" to provide a minimal fix to what is already in master. |
Travis CI failure, but seems entirely unrelated |
bumped it, travis ok now. @ngokevin what do you think? |
bd13d1b
to
f47a61f
Compare
Per discussion on #3429, this is a simpler fix avoiding RegExp usage.