Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use forEach instead of for...of (fixes #3449) #3495

Merged

Conversation

walaszczykm
Copy link
Contributor

@walaszczykm walaszczykm commented Mar 24, 2018

Description:
As described on #3449 if you want to build project which depends on aframe it fails because of ES6 syntax on aframe-master.js:75038. This code comes from a-register-element.js:62

Changes proposed:
I have changed for..of loop:

for (var propName of Object.getOwnPropertyNames(newObj.prototype)){}

to forEach function call:

Object.getOwnPropertyNames(newObj.prototype).forEach(function(propName){})

@walaszczykm
Copy link
Contributor Author

npm run test:firefox -- --single-run crashes for me also on master branch without any changes

@machenmusik
Copy link
Contributor

Yeah, I ran into that while doing #3489 as well. Maybe you can try forcing an empty commit to get it to try again?

@dmarcos
Copy link
Member

dmarcos commented Mar 24, 2018

I restarted the tests

@machenmusik
Copy link
Contributor

yay tests passed

@dmarcos
Copy link
Member

dmarcos commented Mar 24, 2018

Thanks!

@dmarcos dmarcos merged commit 17298cd into aframevr:master Mar 24, 2018
@walaszczykm walaszczykm deleted the remove-es6-from-register-element branch February 25, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants