Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sRGB encoding to perspective screenshot #4822

Merged
merged 1 commit into from
Mar 15, 2021
Merged

add sRGB encoding to perspective screenshot #4822

merged 1 commit into from
Mar 15, 2021

Conversation

kfarr
Copy link
Contributor

@kfarr kfarr commented Mar 14, 2021

Description: add sRGB encoding to perspective screenshot, fixing #4817

@dmarcos
Copy link
Member

dmarcos commented Mar 15, 2021

I fixed the broken tests on master. If you rebase this is ready to merge. Thanks so much for the patience.

@kfarr
Copy link
Contributor Author

kfarr commented Mar 15, 2021

rebased and no worries, I'm always learning new things working with you and the community!

@dmarcos
Copy link
Member

dmarcos commented Mar 15, 2021

Thank you!

@dmarcos dmarcos merged commit 65f02cc into aframevr:master Mar 15, 2021
@diarmidmackenzie
Copy link
Contributor

As per a thread in the slack community, I'm concerned that this fix has had a bad effect on colors in some screenshots.

This is what a screenshot of teh HelloWebVR page looked like in 1.2.0.
screenshot--1645741701810

This is what it looks like in 1.3.0.
screenshot--1645741354272

This glitch shows that if you revert the changes made in this PR, you get back to the previous coloring (i.e. this change is the cause of the difference).
https://glitch.com/edit/#!/sly-sixth-topaz?path=index.html%3A19%3A9

I'll raise a separate issue to track this, but thought it made sense to flag here as well.

@kfarr
Copy link
Contributor Author

kfarr commented Feb 25, 2022

Thanks, replied here: #5014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants