Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Curaçao #320

Closed
stefanvucic opened this issue Oct 20, 2022 · 6 comments
Closed

Support for Curaçao #320

stefanvucic opened this issue Oct 20, 2022 · 6 comments

Comments

@stefanvucic
Copy link

stefanvucic commented Oct 20, 2022

Hello team.
We are successfully using the phone library for some time but a few days ago we faced an issue with the phone number for the country Curaçao. Just wondering if this is a known issue and if there is any plan for supporting Curaçao?

Please refer to the provided images. Thanx in advance!

image

image

@Bossa573
Copy link
Member

Hello,
the data structure would be like this: https://github.com/AfterShip/phone/blob/master/src/data/country_phone_data.ts

{
		alpha2: 'CW',
		alpha3: 'CUW',
		country_code: '5999',
		country_name: 'Curaçao',
		mobile_begin_with: ['5', '6'],
		phone_number_lengths: [7]
},

Reference:
https://www.curacao.com/en/questions/internet-connection-and-cell-service/what-is-the-telephone-code-in-curacao

See if the above setting make sense to you @stefanvucic

@stefanvucic
Copy link
Author

Hello, thanks for the quick reply! I assume this is fine.
We will need to update the phone package version after those changes are applied?

@Bossa573
Copy link
Member

yes if it's fine I'll update and bump the version

@stefanvucic
Copy link
Author

Absolutely! If it is not a problem just send a new version here once it is ready.

Bossa573 added a commit that referenced this issue Oct 20, 2022
Bossa573 added a commit that referenced this issue Oct 20, 2022
- #320 Support for Curaçao
@Bossa573
Copy link
Member

Bossa573 commented Oct 20, 2022

image

https://github.com/AfterShip/phone/releases/tag/3.1.29

https://www.npmjs.com/package/phone/v/3.1.29

the new version is ready

@stefanvucic
Copy link
Author

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants