Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Phone number format] Add more Poland prefix phone number #369

Closed
devmws opened this issue Nov 3, 2023 · 8 comments
Closed

[Phone number format] Add more Poland prefix phone number #369

devmws opened this issue Nov 3, 2023 · 8 comments

Comments

@devmws
Copy link

devmws commented Nov 3, 2023

Hello,

We found some of Poland number are not registered on the mobile_begin_with. Such as prefix +483xx are not on the list. For now, only 4, 5, 6, 7, 8 was on the list. It should also cover for 481 482 483 and 489.

Reference:
https://en.wikipedia.org/wiki/Telephone_numbers_in_Poland

@Bossa573
Copy link
Member

Bossa573 commented Nov 3, 2023 via email

@devmws
Copy link
Author

devmws commented Nov 3, 2023

Hello,

For example, this phone number was a valid phone number from Poland

+48338881574

Thank you.

@Bossa573
Copy link
Member

Bossa573 commented Nov 3, 2023

image

from the wiki, 3 is not part of mobile phone number, will not modify.

https://github.com/AfterShip/phone#help

@Bossa573 Bossa573 closed this as completed Nov 3, 2023
@devmws
Copy link
Author

devmws commented Nov 3, 2023

image from the wiki, 3 is not part of mobile phone number, will not modify.

https://github.com/AfterShip/phone#help

It is the Poland phone number. See this table

image

As an additional reference, the prefix is for a city in Poland called Biała Podlaska

https://en.wikipedia.org/wiki/Bia%C5%82a_Podlaska

@Bossa573
Copy link
Member

Bossa573 commented Nov 3, 2023

No matter if it's a Poland phone number or not, the library will only support MOBILE phone number format. No landline phone number format (or any other phone number format) will be included.

image

@thomasmoon
Copy link

Hi!

This seems like a very healthy and active library that I would easily choose as part of critical business software, but I need the same parsing that will work reliably for any phone number, not just mobile numbers.

Is there a similar library that will work for all phone numbers in the world that is as well maintained as this one?

@Bossa573
Copy link
Member

Bossa573 commented Aug 7, 2024

@thomasmoon maybe you can try google one https://github.com/google/libphonenumber/
but I haven't try it, not sure if it's fully covering all phone numbers though

@thomasmoon
Copy link

Thanks @Bossa573, I eventually found my way there too. A bigger library with a few more features that I wouldn't really need but seems like a good option and also well maintained. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants