-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a generic XML Handler #287
Comments
Thank you for opening this. I want to finish #126 first, which changes the way the XML records are parsed anyway. It should make things easier. But an option to return XML directly sounds fair. You need to work with lido records, yes? Can you provide an example or the XSD? Are you referring to this schema? |
Yes, I work with Lido data, it's the schema you referred to (but not the latest version, see http://www.lido-schema.org/schema/v1.0/lido-v1.0.xsd).
I just had a look at #126, it seems that the xml to data mapping applies to the whole OAI response, that way my previus comment doesn't make that much sense. |
Can you give an example of a lido record (URL) or are these only available through authentication at https://sammlungen.uni-goettingen.de/oai? About your second comment: Yes, the mapping will parse the entire oai response to be able to conveniently access error codes, resumption tokens etc. |
The LIDO records themself are also avail abele for download, just press the LIDO button on top of each sigle record page, like http://sammlungen.uni-goettingen.de/lidoresolver?id=record_kuniweb_592744 I would consider it as a bad practise to include code that's reproducable by build tools, since:
Just make sure your builds are reproduceable, that is make sure to use a defined version of the generator (not just the latest one). |
Alright, let's agree to disagree. I think your arguments are not valid. If you want to discuss #126 further, please comment over there and try to be constructive. |
This issue is stale because it has been open 60 days without activity. |
This issue was closed because it has been stalled for 7 days with no activity. |
Currently the user is required to implement other XML metadata formats on their own, see docs.
There should be a generic class mapping that works this way (pseudo code):
Where
record.metadata
would be a xml.etree.ElementTree. This is important to be able to use document relative calls to.xpath()
, since this way one doesn't have to take the encapsulating OAI Response into account.Otherwise a helper function on the
Record
class, similar toget_metadata
would be nice. From my point of view it's more helpful to interact directly with the XML then writing a handler for mapping complex metadata into a python dictionary.The text was updated successfully, but these errors were encountered: