Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with the theme builder generated css file #7978

Closed
lpachecocacib opened this issue May 17, 2024 · 1 comment
Closed

Issue with the theme builder generated css file #7978

lpachecocacib opened this issue May 17, 2024 · 1 comment

Comments

@lpachecocacib
Copy link

I'm submitting a
[x] bug report

When using the theme builder, the generated css file (the core part of it) is not correct, the last attribute for selector is missing the semicolon, if there's only one attribute it's also missing.

Example :

.ag-list-item-hovered:after{ background-color:var(--ag-range-selection-border-color); content:""; height:1px; left:0; position:absolute; right:0 }

@BernieSumption
Copy link
Contributor

BernieSumption commented May 20, 2024

Thanks for using the new theme builder and taking the time to give feedback.

According to the CSS spec, semi-colons are required between multiple property declarations within a rule, not after every rule. When you're writing CSS it is considered good practice to put semi colons at the end of each line for consistency and maintainability, and we do so in our source files, but the code you're looking at has been minified by cssnano which only emits strictly necessary semi colons.

If this is causing issues for your setup or tooling, feel free to re-open the issue with details of the problems being caused and / or tools that are having issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants