Invalid column state seems improperly handled in setColumnState

[remibd]

Hi!
In the following snippet of code, extracted from dist/ag-grid.js lines 3239 to 3254, the variable oldColumn is sometimes undefined, and oldColumn.setVisible(…) raises an exception:

ColumnController.prototype.setColumnState = function (columnState) {
    var oldColumnList = this.allColumns;
    ...
    if (columnState) {
        columnState.forEach(function (stateItem) {
        var oldColumn = utils_1.Utils.find(oldColumnList, 'colId', stateItem.colId);
        if (!oldColumn) {
            console.warn('ag-grid: column ' + stateItem.colId + ' not found');
            success = false;
        }
        oldColumn.setVisible(!stateItem.hide); // EXCEPTION HERE!
        ...

It looks like it is not the desired behavior, since it might simply cut off the grid generation (and pollutes the console with big flashy red exceptions just after the more tactful console.warn).

Is it the expected behavior?

Thanks in advance

[ceolter]

code above is wrong, it's actually:

                if (!oldColumn) {
                    console.warn('ag-grid: column ' + stateItem.colId + ' not found');
                    success = false;
                    return;
                }

it you are missing the return statement. maybe you are on an older version, what you describe doesn't happen in the latest.

[remibd]

Haven’t you added that return statement yesterday?

[ceolter]

i released yesterday. i can't remember when i actually added it!!