Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace const with static in many places #527

Closed
corwinkuiper opened this issue Dec 9, 2023 · 0 comments · Fixed by #529
Closed

Replace const with static in many places #527

corwinkuiper opened this issue Dec 9, 2023 · 0 comments · Fixed by #529

Comments

@corwinkuiper
Copy link
Collaborator

A const is compiler pasted, therefore multiple uses of one const could cause the data to be duplicated in the ROM. A static avoids this issue. Therefore we should use statics rather than consts for music, sprites, background data, etc.

Very breaking change.
@corwinkuiper corwinkuiper linked a pull request Feb 10, 2024 that will close this issue
Use static rather than const #529
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use static rather than const corwinkuiper/agb-fork
1 participant
@corwinkuiper