Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GHC 9.10.2 #368

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Add support for GHC 9.10.2 #368

merged 2 commits into from
Sep 24, 2024

Conversation

jespercockx
Copy link
Member

This adds support for GHC 9.10.2, and drops support for older versions of GHC (< 9.4.8) from CI to avoid having too many different CI runs.

@jespercockx
Copy link
Member Author

One point of discussion: if people agree with dropping CI for GHC versions prior to 9.4.8, should we also increase the base dependency from 4.13 to 4.17 (the version used by GHC 9.4.*)? In other words, is it better to be loose in the version bounds so people can easily build with older GHCs, or strict so that we can guarantee that building will actually work?

@jespercockx jespercockx merged commit 429a9e3 into agda:master Sep 24, 2024
6 checks passed
@jespercockx
Copy link
Member Author

I merged this for now, we can always bump the version bound later.

@jespercockx jespercockx added this to the 1.3 milestone Sep 24, 2024
@jespercockx jespercockx linked an issue Sep 24, 2024 that may be closed by this pull request
@UlfNorell
Copy link
Member

Usually we base our decisions of which versions to support on what gets shipped with Ubuntu LTS or some such. What's the status of ghc-9.4 there?

@jespercockx
Copy link
Member Author

9.4.8 is the version of ghc currently recommended by ghcup. Since ghcup works so well nowadays, I felt like that was more relevant than whatever is in the Ubuntu LTS.

For reference, Ubuntu 20.04 has ghc 8.8.1, 22.04 has 8.8.4, and 24.04 has 9.4.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support building with GHC 9.10 (base-4.20)
2 participants