Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building with GHC 9.10 (base-4.20) #347

Closed
cho-m opened this issue Jul 31, 2024 · 1 comment · Fixed by #368
Closed

Support building with GHC 9.10 (base-4.20) #347

cho-m opened this issue Jul 31, 2024 · 1 comment · Fixed by #368
Assignees
Milestone

Comments

@cho-m
Copy link

cho-m commented Jul 31, 2024

Lifting the upper bound of base does allow build to succeed:

build-depends: base >= 4.13 && < 4.20,


Opened this as working on updating to GHC 9.10.1 in Homebrew (Homebrew/homebrew-core#178590) and noticed the Homebrew agda formula failed to build with GHC 9.10.1 when building agda2hs.

@jespercockx jespercockx added the bug Something isn't working label Sep 23, 2024
@jespercockx jespercockx added this to the 1.3 milestone Sep 23, 2024
@jespercockx jespercockx removed the bug Something isn't working label Sep 23, 2024
@jespercockx
Copy link
Member

It seems we should get rid of head from our codebase:

src/Agda2Hs/Compile.hs:132:139: error: [GHC-63394] [-Wx-partial, -Werror=x-partial]
    In the use of head
    (imported from Prelude, but defined in GHC.Internal.List):
    "This is a partial function, it throws an error on empty lists. Use pattern matching, 'Data.List.uncons' or 'Data.Maybe.listToMaybe' instead. Consider refactoring to use "Data.List.NonEmpty"."
    |
132 |         genericDocError =<< vcat (map (\x -> text $ "Cannot generate multiple constructors with the same identifier: " <> Hs.prettyPrint (head x)) duplicateCons)
    |                                                                                                                                           ^^^^

@jespercockx jespercockx linked a pull request Sep 24, 2024 that will close this issue
@jespercockx jespercockx self-assigned this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants