Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library type-checking time #748

Open
anuyts opened this issue Mar 27, 2022 · 3 comments
Open

Library type-checking time #748

anuyts opened this issue Mar 27, 2022 · 3 comments

Comments

@anuyts
Copy link
Contributor

anuyts commented Mar 27, 2022

When I run make or typecheck README.agda, this also typechecks modules such as Cubical.Experiments.ZCohomology.Benchmarks, a module which seems almost intended to take a long time to load. Is it strictly necessary for these files to be part of the library and kept permanently up to date by anyone contributing to any of the dependencies?

@mortberg
Copy link
Collaborator

mortberg commented Mar 28, 2022

Would it be possible to set things up so that one can use make to typecheck only the package one is working on?

@anuyts
Copy link
Contributor Author

anuyts commented Mar 28, 2022

Well in this case I probably did change a file that Cubical.Experiments.ZCohomology.Benchmarks depended on.
My point is more that maybe performance benchmarks (is that what they are?) need not be part of a library.

@mortberg
Copy link
Collaborator

mortberg commented Apr 4, 2022

It's some benchmarks for a paper that we don't want to ever break. How about having the general make target not build anything in Experiments but have the CI do? Nothing in the library should depend on something in Experiments anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants