Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not build with GHC 9.2 or 9.4 #2

Open
andreasabel opened this issue Aug 12, 2021 · 12 comments
Open

Does not build with GHC 9.2 or 9.4 #2

andreasabel opened this issue Aug 12, 2021 · 12 comments
Labels
ghc-9.2 help wanted Extra attention is needed
Milestone

Comments

@andreasabel
Copy link
Member

andreasabel commented Aug 12, 2021

GHC 9.2 saw a refactoring of GHC's syntax trees (XRec, GenLocated), so Tags.hs needs to be updated.

Needed if we want to stay on stackage nightly:

@andreasabel andreasabel added this to the 0.1.6 milestone Aug 12, 2021
@andreasabel andreasabel added the help wanted Extra attention is needed label Dec 13, 2021
@andreasabel
Copy link
Member Author

@asr @nad Do we want to maintain hs-tags? Every GHC release will require us to adapt it to the latest GHC API. There are approximate solutions like hasktags that are less maintenance intensive.

@nad
Copy link
Contributor

nad commented Dec 13, 2021

Perhaps there is some tool that provides something that is better (like Agda's jump-to-definition feature).

@andreasabel
Copy link
Member Author

andreasabel commented Oct 19, 2022

Needed if we want to stay on stackage nightly

We dropped out of stackage nightly after 2022-03-17 and are in LTS 19.29 frozen to version 0.1.5.3.

An alternative is https://github.com/arybczak/ghc-tags (currently not in stackage). It aims to the same thing as hs-tags (parse tags via the GHC API), but does not take its configuration from a cabal file:

Maybe we could use the ghc-tags-core library for the heavy lifting and just keep our front-end:

It is licensed under MPL2.0 (Mozilla Public License 2.0) and looks well-maintained (supports GHC 9.4).

@andreasabel andreasabel changed the title Does not build with GHC 9.2 Does not build with GHC 9.2 or 9.4 Oct 19, 2022
@nad
Copy link
Contributor

nad commented Oct 19, 2022

$ cabal install ghc-tags-core
Resolving dependencies...
Error: cabal: Could not resolve dependencies:
[…]

@andreasabel
Copy link
Member Author

andreasabel commented Oct 20, 2022

ghc-tags-core builds with 9.2 but currently not 9.4, waiting for a dependency:

trying: filepath-bytestring-1.4.2.1.11 (dependency of ghc-tags-core)

Unfortunately, this dependency does not have a public bug tracker, it's home seems to be a private wiki: https://joeyh.name/code/haskell-filepath-bytestring/

P.S.: Seems I was in this place already one and a half years ago:

@andreasabel
Copy link
Member Author

Testing that cabal install ghc-tags-core --allow-newer='filepath-bytestring:base' works, I revised the upper bound on base for filepath-bytestring on hackage. So after cabal update, it should build for you, @nad.

@nad
Copy link
Contributor

nad commented Oct 20, 2022

The Hackage page for filepath-bytestring states that this package is deprecated. This, along with the fact that ghc-tags-core did not build under GHC 9.4.2, suggests to me that ghc-tags-core is not maintained very actively.

@andreasabel
Copy link
Member Author

suggests to me that ghc-tags-core is not maintained very actively.

I'd guess that @coot might have a different opinion on this.

@coot
Copy link

coot commented Oct 20, 2022

It is actively maintained, I haven't yet removed filepath-bytestring mostly because I wanted to try out the next version of filepath (which actually is published now, so thanks for the reminder :)).

Ref coot/ghc-tags-plugin#66.

@coot
Copy link

coot commented Oct 20, 2022

There's a PR which introduces it to arybczak/ghc-tags#8.

@nad
Copy link
Contributor

nad commented Oct 21, 2022

It is actively maintained

That's good to know. Thanks!

@coot
Copy link

coot commented Oct 22, 2022

A newer version of filepath-bytestring was published, which compiles with ghc-9.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ghc-9.2 help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants