-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GridSearchCV for data transformers? #24
Comments
Ah, I now see that the exercise 5 solution shows us how to do this. |
Hey, thanks for the kind words, it's always nice to hear! :) |
If I may make a suggestion: it may be helpful to change the wording so that it's clear that this is an exercise, not something we've already learned ("don't forget that..."; "the grid search will automatically..."). And that it's not something we can figure out on our own, but requires us to look up the solution (either once we've gotten to the exercises, or -- since we don't know that a question and answer will be forthcoming -- somewhere on the internet). |
I think I wrote "don't forget" because I already mentioned the idea at the top of page 63:
That said, it may indeed help to be more explicit, thanks for the suggestion. |
Yes, indeed you did. I think what confused me was that we'd only seen GridSearchCV called on an instance of the regressor class, and I don't think we'd seen an example of a pipeline that contained both a transformer and regressor, so it wasn't clear how it was possible to apply it to a transformer. |
Got it, thanks for your feedback, I'll see what I can do to clarify this for future editions. :) |
There's a note that says:
It's not obvious to me how to do this. The given example only shows how to search the parameters of the model, not the data pipeline.
Looking online, it seems that one way is to add the model to the pipeline, and then identify the hyperparameters as stagename__hyperparamname?
Thanks for your fantastic book!
The text was updated successfully, but these errors were encountered: