Rpi config add rpi config strip #1255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The size of the file config.txt is over 52k, and it may grows over the versions of the firmware. Even the deprecated options are maintained. This adds the variable RPI_CONFIG_STRIP to allow the strip down of the file config.txt to the very bare minimal: it removes the leading white spaces, the empty lines and the comments. Signed-off-by: Gilles Doffe <gilles.doffe@rtone.fr> Signed-off-by: Gaël PORTAY <gael.portay@rtone.fr>
The firmware has a size limit in handling config.txt depending the hardware and it may prevent the hardware from booting if file exceeds it. That limit is not documented yet[1] but the links[2][3] mention about 16k. This warns if the config.txt is larger than 16k. [1]: https://www.raspberrypi.com/documentation/computers/config_txt.html [2]: https://forums.raspberrypi.com/viewtopic.php?p=2159238 [3]: raspberrypi/firmware#1848 Signed-off-by: Gaël PORTAY <gael.portay@rtone.fr>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello maintainers,
The
config.txtis taken from repository and it is big.The firmware has a size limit in handling that file which is not documented yet and some say it is 16k.
This PR adds the variable
RPI_CONFIG_STRIPwhich strips the comments, empty lines and leading space (due to${RPI_EXTRA_CONFIG}) if set to"1".The second adds a warning if the deployed
config.txtexceeds 16k.Note: The worst part is that it prevent from the pi 5 to boot.
Regards,
Gaël