Futures must be instantiated with an explicit condition=Condition() parameter

[aglyzov]

We must instantiate Futures with an explicit condition=Condition() parameter where Condition is obtained from _get_green_tools().
Otherwise a Future would use default threading.Condition() and block other greenlets.

Also we need a test case that proves this.

[AxelVoitier]

Well, it kept throwing exceptions when I was using it with greenlets.
Maybe the latest changes on the green tools fixed it. I have to retry.

[AxelVoitier]

Now it works, strange.
I will push the modifications then.

[aglyzov]

Thanks Axel,
By the way in which case it raises a TypeError?

[AxelVoitier]

When the Future class comes from the threading module. It has no kwarg "condition".

[aglyzov]

I see. That's what I thought. I am going to take care of it by replacing get_green_tools() with a more generic get_concurrency_tools() which would also cover the threading case (i.e. no green env). Also it is going to return a proper Future class/wrapper suitable for current env.

[AxelVoitier]

👍 , that would remove the need for abstract _get_tools methods :).