Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply "quick fix" for ibid #174

Closed
warner opened this issue May 22, 2019 · 3 comments
Closed

apply "quick fix" for ibid #174

warner opened this issue May 22, 2019 · 3 comments
Labels
SwingSet package: SwingSet

Comments

@warner
Copy link
Member

warner commented May 22, 2019

#161 describes the problems with our current ibid code. This ticket is about just applying the "quick fix" which disables the creation of ibid markers, so that any shared data structures will simply be duplicated in the encoded data. The biggest flaw of this fix is when the marshaller is asked to serialize an object graph with cycles, which will cause infinite recursion and termination of the host. But that's better than the current situation, in which complex data structures will be arbitrarily corrupted as they traverse the serialization process.

@warner
Copy link
Member Author

warner commented Jun 2, 2019

I think 5899544 might have applied this "quick fix". If so, the fix made it into release 0.0.10.

@erights
Copy link
Member

erights commented Jun 2, 2019

Well, that's the real fix. And it wasn't quick ;)

@erights erights closed this as completed Jun 2, 2019
@warner
Copy link
Member Author

warner commented Dec 4, 2019

in the old repo. this was SwingSet issue 55

@warner warner transferred this issue from Agoric/SwingSet Dec 4, 2019
@warner warner added the SwingSet package: SwingSet label Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SwingSet package: SwingSet
Projects
None yet
Development

No branches or pull requests

2 participants