Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web-components: pursesNotifier updates when no purses have changed #85

Open
samsiegart opened this issue Feb 23, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@samsiegart
Copy link
Contributor

Describe the bug

When using the purses notifier from makeAgoricWalletConnection, it will notify updates intermittently even when no purses have changed. This is because it queries the bank periodically, and doesn't check if the actual results have changed or not since the last query, always triggering a new update.

This is problematic because it can lead to unnecessary re-renders in clients. It should check if the bank value is new before updating.

Note it also uses a chain storage watcher to watch vstorage for other non-bank purses, but this only updates when the values are new, so it's not part of the problem.

@samsiegart samsiegart added the bug Something isn't working label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant