fix: dont throw on missing smart wallet #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsiegart
force-pushed
the
patch-upgrade-12
branch
2 times, most recently
from
0b94418
to
ddf428a
Compare
mhofman
approved these changes
Nov 16, 2023
packages/rpc/src/batchQuery.ts
Outdated
| return [ | ||
| pathToKey(paths[index]), | ||
| { error: entry.result.response.log }, | ||
| { error: { code, codespace, log } }, |
There was a problem hiding this comment.
Wondering if message is not a more appropriate name on the JS side
Suggested change
| { error: { code, codespace, log } }, | |
| { error: { code, codespace, message: log } }, |
| ) { | ||
| smartWalletStatusNotifierKit.updater.updateState( | ||
| harden({ provisioned: false }), | ||
| ); | ||
| } else { | ||
| throw Error(err); | ||
| throw Error(log); |
There was a problem hiding this comment.
further consumers might be interested in the code values to do similar filtering
Suggested change
| throw Error(log); | |
| const err = Error(log); | |
| err.code = code; | |
| err.codespace = codespace; | |
| throw err; |
There was a problem hiding this comment.
I'll opt to keep as is since the proper way is to create a new type (not cast err to any) and export it. This would be a breaking change, and we don't expect the dapps to change how they handle this error with this fix.
samsiegart
force-pushed
the
patch-upgrade-12
branch
from
ddf428a
to
49d94a7
Compare
samsiegart
force-pushed
the
patch-upgrade-12
branch
from
49d94a7
to
08a1a99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #58