feat(web-components): surface wallet connection rpc errors #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
reviewed
Dec 14, 2023
packages/web-components/src/wallet-connection/walletConnection.js
Outdated
Show resolved
Hide resolved
samsiegart
force-pushed
the
wallet-connection-errors
branch
from
09f0d28
to
7289e78
Compare
turadg
approved these changes
Dec 14, 2023
| /** | ||
| * @param {any} chainStorageWatcher | ||
| * @param {string} rpc | ||
| * @param {((error: unknown) => void)=} onRpcError |
There was a problem hiding this comment.
not worth another push, but in agoric-sdk we use jsdoc syntax,
Suggested change
| * @param {((error: unknown) => void)=} onRpcError | |
| * @param {((error: unknown) => void)} [onRpcError] |
samsiegart
force-pushed
the
wallet-connection-errors
branch
from
ee9964f
to
d1432fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs Agoric/agoric-sdk#8505
We improved error handling to the
chainStorageWatcherin #65, but themakeAgoricWalletConnectioncomponent uses the RPC endpoint rather than the API endpoint, and doesn't surface errors conveniently when queries fail. This adds anonRpcErrorparameter so that clients can respond accordingly when the RPC node is failing.Also, made it only call
await Tendermint34Client.connect(rpc)once instead of every time it queries the bank. This removes an extra round trip to reduce load on the RPC node. Also added up to 2 retries aroundqueryBankbecause the tendermint client doesn't do any retries on its own.