Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: move ui-components into web-components #90

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

samsiegart
Copy link
Contributor

@samsiegart samsiegart commented Mar 4, 2024

Motivation

The ui-components package does not export any types, relies on ava for testing as opposed to vitest like the other packages, and has some obsolete components like the MaterialUI react components which require babel. The types in particular have required workarounds such as manually declaring the module which doesn't work super well.

Also, there's some obsolete wallet connection component in web-components that uses the local storage bridge to wallet.agoric.app which doesn't work with the latest browsers.

Changes

This PR removes the ui-components package and moves the non-obsolete components to web-components with properly exported types. Also rewrote the tests in vitest instead of ava. This will make the repo easier to maintain and require clients to manage fewer dependencies.

This PR also removes the old local-storage-reliant wallet connection component and all the associated lit dependencies.

Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. For code history, consider squashing the last two commits. Because you added then removed, Git doesn't know that it was a rename and thus loses the history.

@samsiegart samsiegart changed the title Migrate UI components feat!: move ui-components into web-components Mar 4, 2024
@samsiegart samsiegart merged commit c86103b into main Mar 4, 2024
1 check passed
@samsiegart samsiegart deleted the migrate-ui-components branch March 4, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants